Basic work on making the repl a little nicer to use. #47
+86
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xKitsune
reviewed
Jul 26, 2024
Comment on lines
+91
to
+93
| if e.downcast_ref::<InquireError>().is_some() { | ||
| break | ||
| } |
There was a problem hiding this comment.
Can we update this to mimic how chisel handles ctrl-c?
» chisel
Welcome to Chisel! Type `!help` to show available commands.
# ctrl-c
➜
(To exit, press Ctrl+C again)
➜
# exits
0xKitsune
reviewed
Jul 26, 2024
Comment on lines
+137
to
+142
| let line = tokio::task::spawn_blocking(|| { | ||
| inquire::Text::new("Enter a command") | ||
| .with_help_message("'help' for more information") | ||
| .prompt() | ||
| }) | ||
| .await??; |
There was a problem hiding this comment.
I think we can probably display "Enter a command" once at the beginning. Something like the following
Welcome to Opt8n Type `help` to show available commands.
➜
# some command
➜ What do you think about modeling the repl UX after chisel?
Here is a link to chisel in case you havent used it before!
There was a problem hiding this comment.
This would be very nice, chisel should be a good reference to go off of.
|
Closing for now while cleaning up stale PRs. Feel free to open another PR with the changes if you would like! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.