fix(opdn): Implement from-l2 subcommand with generated fixture #63
+276,852
−462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xKitsune
reviewed
Aug 6, 2024
0xKitsune
reviewed
Aug 6, 2024
|
This is intended to be a draft right now @0xKitsune sorry for the confusion, will let you know when I need reviews :) |
refcell
force-pushed
the
refcell/from-l2
branch
from
5c211c2
to
d4bc1c9
Compare
refcell
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the
from-l2subcommand and fixes up thefrom-l1subcommand to derive the valid payload attributes for the given L1 block range or the L1 blocks needed to derive the given L2 block range.Generated a derivation test fixture with the following command: