feat(optv): Generic Derivation Test Fixtures #74
Merged
+29
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refcell
added
A-op-test-vectors
clabby
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifies the
DerivationFixturemaking it's internal types generic with deserialization and serialization.Moves
kona-deriveto adev-dependencyinop-test-vectorsand removes it's re-export.Motivation
Making derivation fixture types generic allows for different versions of
kona-deriveto be used when deserializing the derivation test fixtures. Previously,kona-derivewas re-exported fromop-test-vectorscausing a conflict in the test runner if using a local, different version ofkona-derive. This PR solves that by making the types internal so the test runner can import and specify the types from a local import ofkona-derive.