Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EIP: Ground Zero #8301

Closed
wants to merge 112 commits into from
Closed

Add EIP: Ground Zero #8301

wants to merge 112 commits into from

Conversation

ProphetZX
Copy link

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@ProphetZX ProphetZX requested a review from eth-bot as a code owner March 11, 2024 11:12
@github-actions github-actions bot added c-new Creates a brand new proposal s-draft This EIP is a Draft t-core labels Mar 11, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Mar 11, 2024

File EIPS/eip-7488.md

Requires 1 more reviewers from @axic, @g11tech, @gcolvin, @lightclient, @SamWilsn

@eth-bot eth-bot added e-consensus Waiting on editor consensus e-review Waiting on editor to review labels Mar 11, 2024
@eth-bot eth-bot changed the title EIP-7488 Ground Zero Add EIP: Ground Zero Mar 11, 2024
Copy link

gitguardian bot commented Mar 11, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- Generic High Entropy Secret 279852f assets/eip-5521/ERC_5521.test.js View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

If this detection is a false positive, please contact Oleh Vasylenko (@Aldekein) to fix it in the GitGuardian dashboard.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!


## Copyright

Ethereum Community, Aperon, ProphetXZ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copyright must CC0, please see the EIP template for correct formatting

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thx

@lightclient
Copy link
Member

lightclient commented Mar 12, 2024

From EIP-1:

Before you begin writing a formal EIP, you should vet your idea. Ask the Ethereum community first if an idea is original to avoid wasting time on something that will be rejected based on prior research. It is thus recommended to open a discussion thread on the Ethereum Magicians forum to do this.

Since this hasn't been vetted yet, I'm going to close this PR. If you can show that some community support exists for this proposal please feel free to reopen.

@ProphetZX
Copy link
Author

ProphetZX commented Mar 15, 2024

Don’t know whether you’ve seen it, but the EIP is referenced in the Ethereum Magicians forum, under https://ethereum-magicians.org/t/eip-ground-zero/15480. However, I meant the actual original community when I wrote the EIP (as far as I know, Eth Magicians has nothing to do with the original community). Are you part of that community?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-new Creates a brand new proposal e-consensus Waiting on editor consensus e-review Waiting on editor to review s-draft This EIP is a Draft t-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants