Update EIP-6800: change tree key hashing #8302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
github-actions
bot
added
c-update
|
✅ All reviewers have approved. |
jsign
commented
Mar 11, 2024
Comment on lines
+142
to
+143
| def hash_point_to_bytes(point: Point) -> int: | ||
| return group_to_scalar_field(point).to_bytes(32, 'little') |
There was a problem hiding this comment.
For more info: gballet/go-ethereum#401 & ethereum/go-verkle#428
There was a problem hiding this comment.
Note that group_to_scalar_field is defined on L38.
eth-bot
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way we do tree key hashing, switching from base field point serialization to mapping to a scalar field and byte serialization.