Update EIP-3670: Align with EOF Megaspec and other EIPs #8305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-update
|
✅ All reviewers have approved. |
chfast
reviewed
Mar 12, 2024
EIPS/eip-3670.md
Outdated
| - Valid initcode returning invalid code | ||
| - Valid initcode returning valid code | ||
| - EOF container with an invalid code at zeroth code section | ||
| - EOF container with an invalid code at code sections placed in various positions |
There was a problem hiding this comment.
Invalid code can be found in code section 0 or some other, test cases should cover that. It is phrased clunkily, I'll rework this. How about
- EOF container with invalid code in one of its code sections (test various code section indices)
?
There was a problem hiding this comment.
I'm a terrible wordsmith here, how about fa60e76 ?
chfast
approved these changes
Mar 12, 2024
eth-bot
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the language of the EIP-3670, to align with EOF Megaspec and other changes in EOF EIPs. Mainly makes independent from the exact spec of EOF contract creation.
The gist of the EIP should remain the same.