Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-2537: Update eip-2537.md #8307

Closed
wants to merge 1 commit into from
Closed

Update EIP-2537: Update eip-2537.md #8307

wants to merge 1 commit into from

Conversation

asanso
Copy link
Contributor

@asanso asanso commented Mar 12, 2024

adding ack

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@asanso asanso requested a review from eth-bot as a code owner March 12, 2024 16:04
@github-actions github-actions bot added c-update Modifies an existing proposal s-review This EIP is in Review t-core labels Mar 12, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented Mar 12, 2024

✅ All reviewers have approved.

@eth-bot eth-bot changed the title Update eip-2537.md Update EIP-2537: Update eip-2537.md Mar 12, 2024
@eth-bot eth-bot enabled auto-merge (squash) March 12, 2024 16:05
Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link

The commit 4ab2658 (as a parent of 27060b8) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Mar 12, 2024
@@ -383,6 +383,10 @@ Strictly following the spec will eliminate security implications or consensus im

Important topic is a "constant time" property for performed operations. We explicitly state that this precompile **IS NOT REQUIRED** to perform all the operations using constant time algorithms.

## Acknowledgements
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry this isn't a valid EIP section

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seen it. It seems odd is not allowed by EIPs though. :)

Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link
Collaborator

@eth-bot eth-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@asanso asanso closed this Mar 13, 2024
auto-merge was automatically disabled March 13, 2024 08:20

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-update Modifies an existing proposal s-review This EIP is in Review t-core w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants