Update EIP-7742: update the required EL headers and the gas fee mechanism #8994
Conversation
github-actions
bot
added
c-update
File
|
|
LGTM! |
|
If I understand it correctly, the proposed mechanism doesn't ensure that the max positive and negative deviation from the target lead to the (more or less) same percentage increase in base fee. Instead, the mechanism scales faster down than up. Check this for details: |
…nism cleanup cleanup cleanup cleanup cleanup fixes cleanup fee fn cleanup fee fn cleanup fee fn cleanup some more cleanup some more cleanup some more cleanup track max apply feedback for excess blob gas on parent gas usage params as in 4844 resolve typo better variable naming cleanup text bring get base fee to eip 4844 definition level as well w.r.t. header arg apply feedback clarification simplify the entire proposal cleanup cleanup apply feedback language cleanup restore previous langauge further cleanup Update EIPS/eip-7742.md Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com> apply feedback rename to blobs per block
g11tech
force-pushed
the
eip7742-blobbasefee-alternative2
branch
from
80cd4a1
to
5b82513
Compare
|
fyi: |
| ```python | ||
| def calc_excess_blob_gas(parent: Header) -> int: | ||
| parent_target_blob_gas = parent.target_blobs_per_block * GAS_PER_BLOB | ||
| if parent.excess_blob_gas + parent.blob_gas_used < parent_target_blob_gas: |
There was a problem hiding this comment.
These 4 lines can be replaced with
return max(parent.excess_blob_gas + parent.blob_gas_used - parent_target_blob_gas, 0)
IMO, this also more intuitively captures the essence of excess_gas, a non-negative accumulation of error, where error=parent.blob_gas_used - parent_target_blob_gas
There was a problem hiding this comment.
i guess we can leave it as it is inline with 4844 style
an alternate and more simplified proposal to #8979
based on the discussion with @bkellerman here: