-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EIP: Double speed for hash_tree_root #8995
Conversation
✅ All reviewers have approved. |
The commit dc94183 (as a parent of 76bcc83) contains errors. |
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
@twoeths could you help review this new EIP PR having work considerably on ssz sha256 internals |
the change makes a lot of sense to me. For lodestar on holesky, it takes ~530ms for |
Per block, the main effort is for the epoch participation flags. On epoch transition, the balance changes increase the load. Both of these scale with number of validators. I don't have exact timings for Nimbus, but if necessary we should create a reference state with 2 epochs worth of blocks for proper measurement. I have added this as an open item to the Ethereum Magicians thread. |
I think we need to evaluate this in a post-MaxEB world. I suspect, it is not going to be a significant improvement when less hashes change in the merkle tree. It is quite an invasive change and benefit is not super obvious imo. we could also make use of different hash functions such as blake3 which is also consistently faster than sha256 (14x) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for draft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All Reviewers Have Approved; Performing Automatic Merge...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deposit
No description provided.