Update ERC-3156: Make ERC-3156 Flash Mint Reference Implementation compliant with its own spec#1591
Open
red-swan wants to merge 2 commits intoethereum:masterfrom
Open
Update ERC-3156: Make ERC-3156 Flash Mint Reference Implementation compliant with its own spec#1591red-swan wants to merge 2 commits intoethereum:masterfrom
red-swan wants to merge 2 commits intoethereum:masterfrom
Conversation
Add check to return zero in `maxFlashLoan` for unsupported tokens The maxFlashLoan function MUST return the maximum loan possible for token. If a token is not currently supported maxFlashLoan MUST return 0, instead of reverting.
Collaborator
File
|
eip-review-bot
changed the title
|
The commit 7b5ba6b (as a parent of 7c08abb) contains errors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add check in
maxFlashLoanfor unsupported tokensAccording to ERC-3156:
However in the Flash Mint Reference Implementation, the
maxFlashLoanfunction returns it's own token's maximum loan amount regardless of thetokenparameter that is provided when called. This PR simply adds a check like inflashFeeto see in the user'stokenparameter isthisand to return correctly based on that check.