fix: typo in JSON payload #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
approved these changes
Dec 7, 2023
|
Thanks! Any chance this fix can be backported to existing releases? |
dapplion
approved these changes
Dec 8, 2023
We'd have to manually hack the json from those releases... is it causing actual problems? |
|
I feel like a new release would be a cleaner soln |
|
Can be done, ideally we can fix the outstanding PRs with v3 block before we do a release though. |
|
Sure, we can wait for a new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A trailing
,prevents the payload to be valid JSON.This is problematic for implementations relying on this data to perform automated validation tests.