Add note on no attestation_data_root #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dapplion
commented
Dec 8, 2023
dapplion
commented
- Address a really old concern raised by Response code when aggregate can't be created #109 where some implementations returned 404 if no aggregate can be built.
rolfyone
reviewed
Dec 8, 2023
Comment on lines
11
to
12
| A 500 error must be returned if no attestation is available for the requested | ||
| `attestation_data_root`. |
There was a problem hiding this comment.
a 500 would be super weird, why are we going with that?
There was a problem hiding this comment.
The sane alternative is a 404, which is not ideal either.
There was a problem hiding this comment.
It's more difinitive, and consistent with what we do when we have routes not found on the states endpoint... I'm happy with that.
This was referenced Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.