Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define electra types and apis #105

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Define electra types and apis #105

merged 4 commits into from
Oct 10, 2024

Conversation

ensi321
Copy link
Contributor

@ensi321 ensi321 commented Oct 8, 2024

Add electra type definition and update apis to include new types.

Also update beacon apis submodule commit to 02d595daf39943430f54aa978f88a5c50d957e64

Follow up of #101

Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had one question but otherwise this looks great, thank you!!

if we update the beacon-apis submodule to at least 492bbbdbcad45249d9a8cd8c23e902c5dfe4ad28 then I think this will be final for pectra broadly

@ralexstokes
Copy link
Member

also looks like the submodule update would help the linter errors

@ensi321 ensi321 marked this pull request as ready for review October 10, 2024 01:55
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@ralexstokes ralexstokes merged commit 5cb324e into ethereum:main Oct 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants