Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two block tests with withdrawal and execution request #4105

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

jtraglia
Copy link
Member

This PR adds two new block processing tests:

  • test_withdrawal_and_withdrawal_request_same_validator -- a partial withdrawal (from the sweep) and a withdrawal request for a particular validator in the same block. The withdrawal request shouldn't work.
  • test_withdrawal_and_switch_to_compounding_request_same_validator -- a partial withdrawal (from the sweep) and a consolidation request (to switch to a compounding validator) in the same block. The validator's excess balance should not be queued.

Copy link
Contributor

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

@jtraglia jtraglia merged commit c84d1c4 into ethereum:dev Jan 29, 2025
23 checks passed
@jtraglia jtraglia deleted the withdrawal-and-request-tests branch January 29, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants