Add a new consolidation test & two new pending deposit tests #4109
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will:
test_basic_consolidation_source_has_less_than_max_effective_balance
-- a test where the source validator (with 0x01 creds) has an effective balance with less than 32 ETH. This shouldn't prevent the consolidation.test_apply_pending_deposit_over_min_activation_next_increment
-- a test where the deposit amount is 33 ETH. There's an existing test with a deposit amount of 32 ETH + 1 Gwei, but that only ensures the client mod's with the effective balance increment. It wouldn't catch a client that forgets to compare with the max effective balance.test_apply_pending_deposit_compounding_withdrawal_credentials_over_max_next_increment
-- a test like the previous one, but it's a compounding validator and the values are bigger: 2049 ETH.