FEAT: Add lint preventing EIP references in backticks #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamWilsn
reviewed
Jun 3, 2024
| re, | ||
| pattern, | ||
| slug, | ||
| found_backticks: false, |
There was a problem hiding this comment.
I don't see where this member is used?
There was a problem hiding this comment.
Hi, I'm sorry for the late response.
What member are you referring to?
There was a problem hiding this comment.
It seems like it gets set to true, but its value is never read.
There was a problem hiding this comment.
Oh, I just noticed, I will fix it.
|
Hello @SamWilsn, I apologies for the delay in closing this issue. Given that the implementation looks correct, the issue might be how the AST is being constructed or traversed. I’m currently investigating how the markdown is being parsed into an AST. Please, let me know if you have any thoughts on this. |
SamWilsn
force-pushed
the
lint-backticks
branch
from
1a7ccf3
to
adc4ec5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90