Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: asset page svg download url #14770

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

wolovim
Copy link
Member

@wolovim wolovim commented Jan 29, 2025

Description

gm 🌞

Within the assets page, images with an accompanying SVG download route to a 404 page when clicked. For example:

Screenshot 2025-01-29 at 9 39 55 AM

The locale in the URL appears to be the issue. Assets are rendering fine when I disable the locale in the corresponding ButtonLink component.

Screenshot 2025-01-29 at 9 39 33 AM

Looks like this may close #14600. The linked PR in that issue might be overkill?

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit f6e9042
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/679a40af7a33d80008a9a6dc
😎 Deploy Preview https://deploy-preview-14770--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
7 paths audited
Performance: 44 (🔴 down 4 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 9 from production)
SEO: 98 (no change from production)
PWA: 59 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@davidfurlong
Copy link

+1 please can this be merged - came here to fix this but seems its been fixed by this

@corwintines corwintines force-pushed the dev branch 2 times, most recently from 8d21119 to ef384b5 Compare February 12, 2025 04:15
@corwintines corwintines merged commit 9bf470c into ethereum:dev Feb 12, 2025
9 of 10 checks passed
Copy link

gitpoap-bot bot commented Feb 12, 2025

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2025 Ethereum.org Contributor:

GitPOAP: 2025 Ethereum.org Contributor GitPOAP Badge

Join the [ethereum.org Discord server](https://ethereum.org/discord) to explore more ways to contribute to the project. Depending on the tasks you complete, you may also unlock additional rewards. Visit [ethereum.org/contributing](https://ethereum.org/contributing) to learn more.

Head to gitpoap.io & connect your GitHub account to mint!Keep buidling, keep learning, and let's grow the Ethereum open-source community together 🌱

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ethereum assets download link for PNG, JPG & SVG icons are invalid
3 participants