[ShadCN]: Migrate CreateAccount Screen #14808
Open
+379
−304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Afeter8
approved these changes
Feb 2, 2025
TylerAPfledderer
force-pushed
the
feat/shadcn-migrate-simulator-create-account-screen
branch
from
54fd7a7 to
34b2322
Compare
TylerAPfledderer
changed the title
TylerAPfledderer
requested review from
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
pettinarip
requested changes
Feb 5, 2025
| > | ||
| <Spinner w={SPINNER_SIZE} h={SPINNER_SIZE} /> | ||
| <Spinner className={SPINNER_SIZE} /> |
There was a problem hiding this comment.
not a blocker but we could set this size directly in the Spinner component as it default value/size
Comment on lines
+17
to
+18
| "shadow-[0_0_7px_0_var(--eth-colors-blackAlpha-800)]", | ||
| "shadow-[0_0_7px_0_var(--eth-colors-whiteAlpha-800)]" |
There was a problem hiding this comment.
lets simplify this by using shadow-md
| `} | ||
| transitionDelay={numToMsString(getDelayFromIndex(index))} | ||
| position="relative" | ||
| className={`[--display-delay:${numToMsString(getDelayFromIndex(index))}] delay-(--display-delay)`} |
| overflow="hidden" | ||
| w="full" | ||
| > | ||
| <div className="h-90 grid w-full grid-cols-4 gap-2 overflow-hidden whitespace-nowrap md:h-[152px]"> |
There was a problem hiding this comment.
Suggested change
| <div className="h-90 grid w-full grid-cols-4 gap-2 overflow-hidden whitespace-nowrap md:h-[152px]"> | |
| <div className="h-[90px] grid w-full grid-cols-4 gap-2 overflow-hidden whitespace-nowrap md:h-[152px]"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create stories and migrate components for the
CreateAccountsimulator screen to Tailwind/ShadCN