RLP decoding #687
Open
RLP decoding #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rodiazet
commented
Aug 16, 2023
rodiazet
commented
- Implement RLP decoding for basic types
- Use it to implement Transaction decoding.
- Add unit tests
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #687 +/- ##
==========================================
+ Coverage 97.60% 97.69% +0.09%
==========================================
Files 95 96 +1
Lines 8645 8985 +340
==========================================
+ Hits 8438 8778 +340
Misses 207 207
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rodiazet
force-pushed
the
rlp-decoding
branch
3 times, most recently
from
ec92650
to
d5dfe89
Compare
gumb0
reviewed
Sep 2, 2023
test/state/rlp.hpp
Outdated
| @@ -119,4 +121,116 @@ inline bytes internal::encode_container(InputIterator begin, InputIterator end) | |||
| content += encode(*it); | |||
| return wrap_list(content); | |||
| } | |||
|
|
|||
| // Load unsigned integral from bytes_view. The destination size must not me smaller than input data. | |||
There was a problem hiding this comment.
Suggested change
| // Load unsigned integral from bytes_view. The destination size must not me smaller than input data. | |
| // Load unsigned integral from bytes_view. The destination size must not be smaller than input data. |
Put this comment above load()
rodiazet
force-pushed
the
rlp-decoding
branch
from
d5dfe89
to
15745e0
Compare
gumb0
reviewed
Sep 2, 2023
test/state/state.hpp
Outdated
| @@ -127,7 +127,7 @@ struct Transaction | |||
|
|
|||
| Type type = Type::legacy; | |||
| bytes data; | |||
| int64_t gas_limit; | |||
| int64_t gas_limit{}; | |||
There was a problem hiding this comment.
Suggested change
| int64_t gas_limit{}; | |
| int64_t gas_limit = 0; |
to be consistent with initializations below
gumb0
reviewed
Sep 12, 2023
test/state/rlp.cpp
Outdated
| @@ -0,0 +1,90 @@ | |||
| // evmone: Fast Ethereum Virtual Machine implementation | |||
| // Copyright 2021 The evmone Authors. | |||
There was a problem hiding this comment.
Suggested change
| // Copyright 2021 The evmone Authors. | |
| // Copyright 2023 The evmone Authors. |
rodiazet
force-pushed
the
rlp-decoding
branch
from
15745e0
to
3a8a2ff
Compare
rodiazet
force-pushed
the
rlp-decoding
branch
from
3a8a2ff
to
0045be6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.