DUPN and SWAPN in EOF only + EOF stack validation

[pdobacz]

Closes #538

Please take an extra look if the invoke specializations added are ok and have no undesired side effects, esp. the advanced counterpart. The compiler made me add the latter, even if it's not used.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (83e7a32) 97.91% compared to head (8458134) 97.91%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #788   +/-   ##
=======================================
  Coverage   97.91%   97.91%           
=======================================
  Files         110      110           
  Lines       10644    10670   +26     
=======================================
+ Hits        10422    10448   +26     
  Misses        222      222           

Flag	Coverage Δ
blockchaintests	60.37% <0.00%> (+0.44%)	⬆️
statetests	62.35% <41.66%> (+0.13%)	⬆️
statetests-silkpre	25.82% <1.58%> (-0.02%)	⬇️
unittests	95.89% <100.00%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
lib/evmone/advanced_analysis.hpp	100.00% <ø> (ø)
lib/evmone/advanced_instructions.cpp	100.00% <ø> (ø)
lib/evmone/baseline.cpp	100.00% <100.00%> (ø)
lib/evmone/baseline_instruction_table.cpp	100.00% <ø> (ø)
lib/evmone/eof.cpp	83.87% <100.00%> (+0.11%)	⬆️
lib/evmone/instructions.hpp	100.00% <100.00%> (ø)
test/unittests/eof_validation_test.cpp	100.00% <100.00%> (ø)
test/unittests/evm_eip663_dupn_swapn_test.cpp	100.00% <100.00%> (ø)

[chfast]

@rodiazet please review because some things overlap with #742

[chfast]

The compiler made me add the latter, even if it's not used.

I think the compiler generates these functions anyway, they are just not assigned to the instruction table.

[chfast]

The "Fix" is a bit misleading. Maybe change the commit title to

Change the stack_height_required range to accommodate DUPN/SWAPN

[chfast]

A test for legacy code where the result is EVMC_UNDEFINED_INSTRUCTION is missing.

[pdobacz]

The "Fix" is a bit misleading. Maybe change the commit title to

Change the stack_height_required range to accommodate DUPN/SWAPN

I'm planning to squash. The commit was split out for the sake of review back&forth

A test for legacy code where the result is EVMC_UNDEFINED_INSTRUCTION is missing.

👍

[pdobacz]

@rodiazet please review because some things overlap with #742

@rodiazet @chfast Folks, I took a look at #742 myself and it seems both PRs add an invoke overload, a different one. I will assume that the conflict will be easily resolvable and go ahead to merge this.