Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: New State transition tests #806

Merged
merged 1 commit into from
Mar 13, 2024
Merged

test: New State transition tests #806

merged 1 commit into from
Mar 13, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Feb 1, 2024

New tests for:

  • contract creation,
  • account touches,
  • empty coinbase,
  • selfdestruct,
  • extcode.

These tests come from the work on #802 so may not be very coherent.

@chfast chfast requested review from gumb0 and rodiazet February 1, 2024 15:10
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.11%. Comparing base (c65d75e) to head (b951b55).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #806      +/-   ##
==========================================
+ Coverage   98.05%   98.11%   +0.06%     
==========================================
  Files         117      119       +2     
  Lines       11487    11752     +265     
==========================================
+ Hits        11264    11531     +267     
+ Misses        223      221       -2     
Flag Coverage Δ
blockchaintests 59.75% <ø> (ø)
statetests 62.14% <ø> (ø)
statetests-silkpre 23.48% <0.00%> (-0.54%) ⬇️
unittests 96.66% <100.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
test/unittests/state_transition_call_test.cpp 100.00% <100.00%> (ø)
test/unittests/state_transition_create_test.cpp 100.00% <100.00%> (ø)
test/unittests/state_transition_extcode_test.cpp 100.00% <100.00%> (ø)
...t/unittests/state_transition_selfdestruct_test.cpp 100.00% <100.00%> (ø)
test/unittests/state_transition_touch_test.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@chfast chfast force-pushed the test/state_transition_root_hash branch 2 times, most recently from e45666b to fd1e894 Compare February 2, 2024 08:35
Base automatically changed from test/state_transition_root_hash to master February 2, 2024 08:55
@chfast chfast changed the base branch from master to test/export February 2, 2024 09:27
@chfast chfast force-pushed the test/export branch 2 times, most recently from 2680d79 to bae296a Compare February 26, 2024 10:13
@chfast chfast force-pushed the test/export branch 3 times, most recently from c19a78e to 11cfcf6 Compare February 28, 2024 10:15
Base automatically changed from test/export to master February 28, 2024 10:30
@gumb0
Copy link
Member

gumb0 commented Mar 4, 2024

Needs rebase.

@chfast chfast force-pushed the test/state_transition branch 2 times, most recently from 217402b to 7583240 Compare March 5, 2024 09:18
@chfast
Copy link
Member Author

chfast commented Mar 5, 2024

Needs rebase.

Done. Also added some tests for extcode.

New tests for:
- contract creation,
- account touches,
- empty coinbase,
- selfdestruct,
- extcode.
Copy link
Collaborator

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The conflict on the extcode test file should be resolvable by just combining the 2 files, the tests in master are brand new tests for EOF-extcode behavior

@chfast chfast merged commit 75e4ac5 into master Mar 13, 2024
25 checks passed
@chfast chfast deleted the test/state_transition branch March 13, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants