Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid potential overflow in num_words #945

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid potential overflow in num_words #945

wants to merge 2 commits into from

Conversation

yperbasis
Copy link
Member

No description provided.

@yperbasis yperbasis requested review from chfast and rodiazet July 3, 2024 22:06
@chfast
Copy link
Member

chfast commented Jul 4, 2024

Does this fix practical issues or just static analysis warnings?

@yperbasis
Copy link
Member Author

Does this fix practical issues or just static analysis warnings?

It fixes a potential vulnerability in the cost of precomplies (e.g. sha256_analyze), albeit those are only used for tests at the moment.

@yperbasis yperbasis mentioned this pull request Jul 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast Awaiting requested review from chfast

@rodiazet rodiazet Awaiting requested review from rodiazet

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yperbasis @chfast