Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: rename for 7002 partial withdrawals and 7685 requests #535

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

lightclient
Copy link
Member

@lightclient lightclient commented Apr 18, 2024

This PR makes good on some pending changes to 6110 and 7002. It was discussed a roughly accepted in CL call 132.

These three in particular:

The result is DepositReceiptV1 -> DepositRequestV1 and ExitV1 -> WithdrawalRequestV1.

Copy link
Contributor

@ensi321 ensi321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Do you want to change the payload schema and method under openrpc as well?

@lightclient
Copy link
Member Author

Ah thanks for the reminder @ensi321. It's been updated.

Copy link
Collaborator

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for a couple of small things

src/engine/prague.md Outdated Show resolved Hide resolved
src/engine/prague.md Outdated Show resolved Hide resolved
Co-authored-by: lightclient <lightclient@protonmail.com>
Co-authored-by: Mikhail Kalinin <noblesse.knight@gmail.com>
@lightclient
Copy link
Member Author

@mkalinin good catches - fixed now.

@mkalinin mkalinin merged commit 7907424 into ethereum:main Apr 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants