pytest: Parametrize fork covariant parameters #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioevz
changed the title
danceratopz
reviewed
Aug 16, 2023
danceratopz
reviewed
Aug 16, 2023
Co-authored-by: Dan <danceratopz@gmail.com>
marioevz
force-pushed
the
tx-precompiles-marks
branch
from
334d634
to
ba0a3cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Included
Forks
Forks now have
tx_typesandprecompilesmethods, which must return all valid transaction types and enabled precompiles in the given fork.Pytest Plugins: Forks
Introduce covariant parameter markers, which allow to parametrize a test with all valid values for a given property on a given fork.
@pytest.mark.with_all_tx_types@pytest.mark.with_all_precompilesE.g. using
@pytest.mark.with_all_tx_typesthe tester can now specify that the test must be parametrized on each fork with all the valid transaction type numbers as a parameter at that specific fork, (Shanghai:[0, 1, 2], Cancun:[0, 1, 2, 3]), and eventually, on future forks, it should be parametrized using newer transaction types.