-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all: Replace t8n call with internal withdrawals root calculation #273
all: Replace t8n call with internal withdrawals root calculation #273
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! Nice trick with the mypy stubs!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just spotted this, just a small comment/question.
See also marioevz#9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one! Personally not the biggest fan of usingstubs/trie
but can see the use of stubs/
for other things in the future :D
Yeah, it's not ideal :/ Hopefully we don't need it often. |
@danceratopz Made the changes of your comment in the latest commit 👍 Next stop, get rid of |
Removes the unnecessary call to t8n to calculate the withdrawals root with an internal method.
Imports
trie
for this, which did not have type stubs, so a file with only the necessary stubs was generated.