Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Replace t8n call with internal withdrawals root calculation #273

Merged
merged 6 commits into from
Aug 25, 2023

Conversation

marioevz
Copy link
Member

Removes the unnecessary call to t8n to calculate the withdrawals root with an internal method.

Imports trie for this, which did not have type stubs, so a file with only the necessary stubs was generated.

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! Nice trick with the mypy stubs!

Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just spotted this, just a small comment/question.

src/ethereum_test_tools/spec/state_test.py Outdated Show resolved Hide resolved
@danceratopz
Copy link
Member

See also marioevz#9

Copy link
Collaborator

@spencer-tb spencer-tb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Personally not the biggest fan of usingstubs/trie but can see the use of stubs/ for other things in the future :D

@marioevz
Copy link
Member Author

Nice one! Personally not the biggest fan of usingstubs/trie but can see the use of stubs/ for other things in the future :D

Yeah, it's not ideal :/ Hopefully we don't need it often.

@marioevz
Copy link
Member Author

@danceratopz Made the changes of your comment in the latest commit 👍

Next stop, get rid of calc_state_root!

@marioevz marioevz merged commit daac9f0 into ethereum:main Aug 25, 2023
5 checks passed
danceratopz added a commit to danceratopz/execution-spec-tests that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants