-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fw): verkle pydantic rebase and t8n changes #507
Merged
spencer-tb
merged 9 commits into
ethereum:verkle/main
from
spencer-tb:verkle/pydantic-rebase
Jun 14, 2024
Merged
feat(fw): verkle pydantic rebase and t8n changes #507
spencer-tb
merged 9 commits into
ethereum:verkle/main
from
spencer-tb:verkle/pydantic-rebase
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 12, 2024
spencer-tb
force-pushed
the
verkle/pydantic-rebase
branch
2 times, most recently
from
April 12, 2024 16:45
28b389a
to
5ca669d
Compare
spencer-tb
changed the title
feat(fw): verkle pydantic rebase
feat(fw): verkle pydantic rebase and t8n changes
Apr 12, 2024
spencer-tb
force-pushed
the
verkle/pydantic-rebase
branch
from
May 13, 2024 15:06
5ca669d
to
3462127
Compare
feat(ci): use solc-select for tox.
spencer-tb
force-pushed
the
verkle/pydantic-rebase
branch
3 times, most recently
from
June 10, 2024 05:23
791159f
to
1051c1e
Compare
spencer-tb
force-pushed
the
verkle/pydantic-rebase
branch
from
June 10, 2024 05:33
1051c1e
to
62638ea
Compare
fix(ci): add solc-select to fill stage.
spencer-tb
force-pushed
the
verkle/pydantic-rebase
branch
2 times, most recently
from
June 14, 2024 07:54
b28a4b3
to
410b5d1
Compare
spencer-tb
force-pushed
the
verkle/pydantic-rebase
branch
from
June 14, 2024 08:50
191653f
to
9f19719
Compare
spencer-tb
added a commit
that referenced
this pull request
Jun 26, 2024
* feat(fw|tests): add changes for verkle transition tests. --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
spencer-tb
added a commit
that referenced
this pull request
Jun 26, 2024
* feat(fw|tests): add changes for verkle transition tests. --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
spencer-tb
added a commit
that referenced
this pull request
Jul 1, 2024
* feat(fw|tests): add changes for verkle transition tests. --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
spencer-tb
added a commit
to spencer-tb/execution-spec-tests
that referenced
this pull request
Jul 30, 2024
* feat(fw|tests): add changes for verkle transition tests. --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
spencer-tb
added a commit
to spencer-tb/execution-spec-tests
that referenced
this pull request
Jul 30, 2024
* feat(fw|tests): add changes for verkle transition tests. --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
spencer-tb
added a commit
to spencer-tb/execution-spec-tests
that referenced
this pull request
Aug 8, 2024
* feat(fw|tests): add changes for verkle transition tests. --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
spencer-tb
added a commit
that referenced
this pull request
Aug 8, 2024
* feat(fw|tests): add changes for verkle transition tests. --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
spencer-tb
added a commit
that referenced
this pull request
Aug 13, 2024
* feat(fw|tests): add changes for verkle transition tests. --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
spencer-tb
added a commit
to spencer-tb/execution-spec-tests
that referenced
this pull request
Aug 30, 2024
* feat(fw|tests): add changes for verkle transition tests. --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
spencer-tb
added a commit
to spencer-tb/execution-spec-tests
that referenced
this pull request
Aug 30, 2024
* feat(fw|tests): add changes for verkle transition tests. --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
spencer-tb
added a commit
to spencer-tb/execution-spec-tests
that referenced
this pull request
Sep 3, 2024
* feat(fw|tests): add changes for verkle transition tests. --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
spencer-tb
added a commit
to spencer-tb/execution-spec-tests
that referenced
this pull request
Sep 5, 2024
* feat(fw|tests): add changes for verkle transition tests. --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
spencer-tb
added a commit
to spencer-tb/execution-spec-tests
that referenced
this pull request
Sep 5, 2024
* feat(fw|tests): add changes for verkle transition tests. --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
spencer-tb
added a commit
to spencer-tb/execution-spec-tests
that referenced
this pull request
Oct 1, 2024
* feat(fw|tests): add changes for verkle transition tests. --------- Co-authored-by: Mario Vega <marioevz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Adds specific changes from #465 & #485, including a rebase onto main after the pydantic PR #486.
Usage
Use the following geth branch
gballet/t8n-verkle-exec
to *both fill and execute tests.Fill tests with the following commands (until we update the framework fully).
Execute tests using the
consume rlp
eest based hive simulator. Run the following command after generating the tests:Future Todos
STILL TO BE UPDATED
Tweaks
VerkleTree
model and its integration within theTransitionToolOutput
model.Fixture Validation
evm verkle tree-keys
command to convert the post state expected allocation to its verkle tree representation. Compare these values with those from the final verkle tree output from t8n. Example subcommand usage below for an idea of what happens when calling the command:evm t8n ... --output.witness
to each block in the fixture, furthermore utilize during filling to backtest the vkt keys and values against the witness generated for each block.Basic Fixture Execution
consume rlp
simulator.The below errors all occur on the first verkle block, and look to be from the same cause:
evm blocktest
command. Note the following error below. This can be ran within the same directory as fill.engine_newPayloadV2
, against the dockerized client under test. Currently we get a similar error. But from the engine new payload method.This can be ran on the following branch - https://github.com/spencer-tb/hive/tree/verkle/pyspec using this command below. We are using the
kaustinan-with-shapella
geth branch.Further Fixture Generation and Execution
Once we are passing the basic fixture generation we should add the verkle transition for all tests.
Furthermore, add the filling and exection of all these tests starting from Prague. Note the input alloc to t8n will no longer exist in this case so we should first convert it using the
evm verkle tree-keys
subcommand to VKT reprenstation.🔗 Related Issues & PRs
None
✅ PR Checklist
mkdocs serve
locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.