Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rlp): fix indexing in block rlp filenames #577

Merged

Conversation

danceratopz
Copy link
Member

@danceratopz danceratopz commented May 29, 2024

🗒️ Description

This PR fixes the indices used in the block RLP filenames (000n.rlp) that get created in the client container. n should start from 1 (block 1), not 0 (genesis).

This was an oversight in the initial rlp implementation and brings the *.rlp file naming inline with the Hive consensus simulator:
image

🔗 Related Issues

None.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md. SKIP
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@danceratopz danceratopz added type:bug Something isn't working scope:fw Scope: Framework (evm|tools|forks|pytest) labels May 29, 2024
@danceratopz danceratopz requested a review from marioevz May 29, 2024 20:59
@spencer-tb spencer-tb added the scope:consume Scope: Consume command suite label May 30, 2024
@danceratopz danceratopz merged commit 24adc6f into ethereum:main May 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:consume Scope: Consume command suite scope:fw Scope: Framework (evm|tools|forks|pytest) type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants