Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clis/transition_tool): Pass state_test to transition tool if supported #943

Merged
merged 4 commits into from
Nov 7, 2024

Conversation

marioevz
Copy link
Member

@marioevz marioevz commented Nov 6, 2024

πŸ—’οΈ Description

Pass the state_test property to the t8n that support/require it.

In this PR the only updated tool is EELS, and the information is passed as an URL parameter, which is then converted to a CLI argument on the receiving end.

Requires:

πŸ”— Related Issues

None

βœ… Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@marioevz marioevz added scope:evm Scope: evm_transition_tool package type:feat type: Feature labels Nov 6, 2024
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM.

But FYI, I didn't try the resolver fork locally.

I did try Besu locally, as I didn't understand why it still worked - from the code it's obvious though, BesuTransitionTool doesn't override _server_post(), it uses `evaluate() for its implementation. This is a little surprising and the issue to clean this up already exists: #818.

@marioevz
Copy link
Member Author

marioevz commented Nov 7, 2024

We might need to wait until ethereum/execution-specs#1030 and petertdavies/ethereum-spec-evm-resolver#5 merge before proceeding.

@marioevz
Copy link
Member Author

marioevz commented Nov 7, 2024

From the passing CI results, I think that we might not have to wait until the other two branches are merged, since we are passing the parameters, but it's not a breaking change in the receiving side since they simply ignored.
Will merge now.

@marioevz marioevz merged commit ec65b3b into main Nov 7, 2024
5 checks passed
@marioevz marioevz deleted the state-test-to-t8n branch November 7, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:evm Scope: evm_transition_tool package type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants