refactor: modexp exponent_head stricter type #1152
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enitrat
pushed a commit
to kkrt-labs/keth
that referenced
this pull request
Mar 11, 2025
Close #965 Close #954 Change the execution specs repo to kkrt-labs one waiting on [PR on execution specs to be merged](ethereum/execution-specs#1152).
SamWilsn
approved these changes
Mar 13, 2025
This was referenced Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
exponent_head can have a stricter type
How was it fixed?
Change from Uint to U256: exponent_head are the first 32 bytes of the exponent given by
buffer_read(data, exp_start, min(U256(32), exp_length)). There is no need for an unbound type as it should fit into a U256.