eth/downloader: add missing Requests field #30423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
islishude
requested review from
karalabe,
holiman and
rjl493456442
as code owners
islishude
force-pushed
the
fix-eip6110-p2p
branch
from
399e2cb
to
caa2501
Compare
islishude
changed the title
|
I will make a new pr for the validation due to the eip is having a change. the body validation is still required, the peer can send wrong request body but correct request hash to deceive network. |
islishude
changed the title
|
the block will not have the Requests after ethereum/EIPs#8908 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is missing Requests field