beacon/engine,eth/catalyst: hex marshal requests in engine api #30603
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #30584 I was mostly trying to sort out the issues in t8n, now I've run into similar unmarshaling issues in the engine API. Currently the methods like
NewPayloadV4
define requests as[][]byte
, but this doesn't handle hex correctly.The two solutions to this seems to be:
RequestsList
with the decoding methodshexutil.Bytes
I went with the second option in this PR. It seems overkill to create a fully new type. However, what gives me pause is the interface for
BlockToExecutableData
now takes in[]hexutil.Bytes
. We could keep it as[][]byte
, but that would require some data shuffling to convert from the[]hexutil.Bytes
. Not sure if people have a preference on that parameter type.