Fix std::string token type name in LanguageServer semantic tokens
#15758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to the Solidity compiler! A team member will follow up shortly. If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother. If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix. |
cameel
reviewed
Jan 23, 2025
cameel
previously approved these changes
Jan 23, 2025
|
@cameel ready |
cameel
reviewed
Jan 24, 2025
Comment on lines
-2532
to
+2533
| std::string const& license = licenseNames.front(); | ||
| if (regex_match(license, licenseNameRegex)) | ||
| std::string const& license = licenseNames.front(); | ||
| if (regex_match(license, licenseNameRegex)) |
There was a problem hiding this comment.
Note that we use tabs, not spaces for indentation in C++ files. The indentation for if is also now broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Removes incorrect
std::prefix from string token type in semantic tokens legend. This fixes the token type name to match LSP specification requirements.Changed:
tokenTypes.emplace_back("std::string")->tokenTypes.emplace_back("string")