Reorganize database migrations #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuzdogan
approved these changes
Jan 31, 2025
manuelwedler
force-pushed
the
reorganise-db-migrations
branch
from
7b79d2b to
ea25237
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1865
This reduces our db migrations to two files: one for VerA db spec and one for the Sourcify changes to it. The VerA database-specs is added as a git submodule, and its
schema.sqlfile is just read in the first migration, instead of duplicating the code.In the future, when VerA db specs are updated, we just need to update the submodule commit. Sourcify additions should just be added to the Sourcify migration file.