feat: blockchain rpc http transport config#5420
Open
gacevicljubisa wants to merge 3 commits intomasterfrom
Open
feat: blockchain rpc http transport config#5420gacevicljubisa wants to merge 3 commits intomasterfrom
gacevicljubisa wants to merge 3 commits intomasterfrom
Conversation
gacevicljubisa
requested review from
acud,
akrem-chabchoub,
janos,
martinconic and
sbackend123
Contributor
akrem-chabchoub
left a comment
akrem-chabchoub
left a comment
There was a problem hiding this comment.
We should update the docker-compose.yaml with new flags.
acud
reviewed
Apr 2, 2026
| if cmd.Flags().Lookup(v) == nil { | ||
| // Accept both the exact flag name and the dotted form used by nested | ||
| // YAML (e.g. "blockchain-rpc.endpoint" maps to "--blockchain-rpc-endpoint"). | ||
| if cmd.Flags().Lookup(v) == nil && cmd.Flags().Lookup(strings.ReplaceAll(v, ".", "-")) == nil { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Problem
The blockchain RPC client used Go's default HTTP transport with no tuning. When RPC endpoints sit behind a load balancer (e.g. HAProxy with
timeout http-keep-alive 5s), idle connections are silently dropped, causing intermittent EOF errors on the next request.Solution
Expose HTTP transport knobs as CLI flags and wire them into a custom
http.Clientpassed to the RPC dialer viarpc.WithHTTPClient.New flags with recommended defaults:
--blockchain-rpc-dial-timeout30s--blockchain-rpc-tls-timeout10s--blockchain-rpc-idle-timeout90s--blockchain-rpc-keepalive30sSetting
idle-timeoutbelow the load balancer's keep-alive timeoutprevents reuse of connections that have already been silently closed.
Config
Both flat and nested YAML are supported. If both are present, nested
takes precedence and a warning is logged. CLI flags always win.
CheckUnknownParamsnow accepts dotted config keys so nested YAMLdoes not trigger the unknown parameter error.
Closes #5404
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
AI Disclosure