(zh)Fix Uniswap LP fee example math; clarify AMM pricing & DEX slippage; add impermanent loss note #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nent loss note This PR makes three accuracy-focused improvements to the Uniswap/AMM section: 1.Fix LP fee example (math & consistency) The previous example stated a pool of 1 ETH + 5000 USDC but claimed the swap output was ~453.31 USDC (with 0.997 ETH effective input). That output corresponds to a pool of 10 ETH + 5000 USDC under constant-product AMM. The example is updated to use 10 ETH + 5000 USDC, and the LP-share explanation is adjusted to remain internally consistent. 2.Clarify AMM wording Replaces the imprecise claim that AMM “keeps total value balanced” with a more accurate explanation: pricing is determined by reserve ratios and adjusts continuously; large trades relative to pool size create noticeable slippage. 3.Add an impermanent loss (IL) reminder Adds a short note that LP net returns depend on fees minus impermanent loss and costs, to avoid the misconception that providing liquidity is “guaranteed profit”. These changes aim to improve correctness for beginners while keeping the original structure and teaching intent intact.
swen-chan
changed the title
swen-chan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves factual accuracy and avoids common beginner misconceptions in the Uniswap/AMM section:
1.Fix LP fee example (math error)
The previous example stated a pool of 1 ETH + 5000 USDC but claimed the swap output was ~453.31 USDC with 0.997 ETH effective input.
That output corresponds to a pool of 10 ETH + 5000 USDC under constant-product AMM. The example is updated to use 10 ETH + 5000 USDC.
2.Clarify AMM description
Replaces the imprecise claim that AMM “keeps total value balanced” with a more accurate explanation: 它確保報價由池子儲備比例決定並連續調整；當交易規模相對池子較大時，會出現明顯滑點。
3.Add an impermanent loss (IL) reminder
Adds a short note that LP net returns depend on fees minus impermanent loss and costs, to avoid the misconception that providing liquidity is “guaranteed profit”.
4.DEX comparison: add slippage caveat for large trades
Adds a concise note in the DEX characteristics that large trades may face higher slippage (especially in shallow pools), improving realism without expanding scope.
These changes aim to improve correctness for beginners, which is also the target reader of the internship Handbook.