Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeerDAS: Column distribution table #132

Merged
merged 25 commits into from
Oct 15, 2024
Merged

PeerDAS: Column distribution table #132

merged 25 commits into from
Oct 15, 2024

Conversation

skylenet
Copy link
Member

@skylenet skylenet commented Sep 23, 2024

This feature is disabled by default and has to be enabled via config. FRONTEND_SHOW_PEER_DAS_INFOS=true or in the yaml config file via frontend.showSensitivePeerInfos: true.

Add capabilities to extract information related to peerDAS from all peers. With this we can generate a column distribution table where we have an overview about columns that are under peer custody.

Some notable changes/features:

  • Always showing the most up-to-date ENR info from peers based on the peer that has the highest seq field. ENRs from other peers can be out of sync. Example NodeA sees PeerA with ENR seq=10 while NodeB still reports PeerB with an ENR with an older seq=2.
  • When clicking on a node on the PeerDAS table, you'll get a modal popup with detailed node infos. You can also click its peers and navigate from there onwards.
  • Allows filtering the PeerDAS Table by peer type ( internal, external, supernode) and also using the search box.
  • Added a warning button that appears when there's some problem. Clicking on the button results on a modal appearing with more details about the problem. These can be:
    • Could not obtain PeerDAS relevant spec values from the beacon API
    • A peer doesn't have an ENR. Some nodes don't have an ENR for a given peer, thus we can't calculate the right distribution across columns due to the missing CSC field from the ENR. When this happens, we just default to the default custody requirement from the spec
    • The ENR exists but the csc field is not present.
    • There are empty columns, without a peer in it.

Example screenshots:

PeerDAS column overview table

image

Peer details modal when clicking on a node of the PeerDAS column table

image

Example warnings

image

Warning about an outdated ENR, and that the data is based on another node.

image

@skylenet skylenet marked this pull request as ready for review October 14, 2024 09:29
templates/clients/clients_cl.html Outdated Show resolved Hide resolved
templates/clients/clients_cl.html Outdated Show resolved Hide resolved
static/js/common.js Outdated Show resolved Hide resolved
static/js/common.js Outdated Show resolved Hide resolved
@skylenet skylenet merged commit 3dce8bb into master Oct 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants