-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PeerDAS: Column distribution table #132
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is disabled by default and has to be enabled via config.
FRONTEND_SHOW_PEER_DAS_INFOS=true
or in the yaml config file viafrontend.showSensitivePeerInfos: true
.Add capabilities to extract information related to peerDAS from all peers. With this we can generate a column distribution table where we have an overview about columns that are under peer custody.
Some notable changes/features:
seq
field. ENRs from other peers can be out of sync. Example NodeA sees PeerA with ENRseq=10
while NodeB still reports PeerB with an ENR with an olderseq=2
.CSC
field from the ENR. When this happens, we just default to the default custody requirement from the speccsc
field is not present.Example screenshots:
PeerDAS column overview table
Peer details modal when clicking on a node of the PeerDAS column table
Example warnings
Warning about an outdated ENR, and that the data is based on another node.