Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: docker login to separate action yaml #819

Merged
merged 17 commits into from
Oct 31, 2024

Conversation

skylenet
Copy link
Member

@skylenet skylenet commented Oct 30, 2024

  • Only run docker login if credentials are available.
  • Print rate limits.

@skylenet skylenet changed the title ci: docker login to separate action yaml fix: docker login to separate action yaml Oct 30, 2024
@skylenet
Copy link
Member Author

CI currently failing due to kurtosis-tech/kurtosis#2579

Need to wait to get a new kurtosis release

@skylenet
Copy link
Member Author

Ci jobs on main branch were updated to use kurtosis 1.3.1 , so that we don't have the docker auth bug. CI tests pass again now.

@skylenet skylenet merged commit 2494022 into main Oct 31, 2024
11 checks passed
@skylenet skylenet deleted the skylenet/docker-login-when-got-secrets branch October 31, 2024 13:30
skylenet pushed a commit that referenced this pull request Nov 1, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.4.0](4.3.0...4.4.0)
(2024-11-01)


### Features

* add checkpoint sync capabilities to nimbus
([#804](#804))
([853417e](853417e))
* add commit-boost support
([#779](#779))
([ebbbe83](ebbbe83))
* add docker authentication
([#816](#816))
([807f6aa](807f6aa))
* add peerdas metrics dashboard
([#790](#790))
([12b787d](12b787d))
* add rbuilder remove old geth builder - flashbots
([#786](#786))
([de95c61](de95c61))
* add resource configuration for prometheus and grafana
([#773](#773))
([d296c26](d296c26))
* add supernode label to every container
([#788](#788))
([43edfd5](43edfd5))
* add support for fulu/osaka fusaka
([#798](#798))
([0a9e445](0a9e445))
* add support for remote signers - `use_remote_signer`
([#791](#791))
([9f1b6e9](9f1b6e9))
* enable one parameter supernode, refactor el,cl,vc
([#778](#778))
([8513c06](8513c06))


### Bug Fixes

* add database config to assertoor
([#783](#783))
([56532cf](56532cf))
* add nimbus-eth1 net-key
([#811](#811))
([c91bbbb](c91bbbb))
* delete unnecessary port assignment for prysm
([#810](#810))
([47204c3](47204c3))
* docker login to separate action yaml
([#819](#819))
([2494022](2494022))
* get volume size recommendations when in shadowfork mode
([#820](#820))
([b1f27c6](b1f27c6))
* mixed up labels
([#799](#799))
([e2c1528](e2c1528))
* only set supernode if its true
([#796](#796))
([2110a60](2110a60))
* prefund container suffixes for k8s
([#818](#818))
([968cfbd](968cfbd))
* remove deprecated http-allow-sync-stalled from LH
([#805](#805))
([1825dbf](1825dbf))
* Remove not necessary "/api" (and bump verifier version)
([#792](#792))
([befde97](befde97))
* set default for label-maker
([#797](#797))
([5b2d234](5b2d234))
* swap http/grpc server ports and replace flags
([#802](#802))
([8c6df26](8c6df26))
* update built in assertoor tests
([#782](#782))
([d24fb2a](d24fb2a))
* update nethermind config option
([#824](#824))
([08ce034](08ce034))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants