Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hildr #42

Merged
merged 8 commits into from
Jul 15, 2024
Merged

feat: add hildr #42

merged 8 commits into from
Jul 15, 2024

Conversation

barnabasbusa
Copy link
Contributor

No description provided.

@barnabasbusa barnabasbusa linked an issue Jun 27, 2024 that may be closed by this pull request
@barnabasbusa
Copy link
Contributor Author

cc: @GrapeBaBa

@barnabasbusa
Copy link
Contributor Author

optimism-java/hildr#172 is currently a blocker. op-batcher can't connect to op-cl-1-hildr, and thus unable to get the chain info. We need rpc addr to be set to 0.0.0.0 in order to make the node's ports reachable from another container.

@thinkAfCod
Copy link

The sequencer functionality of hildr is not yet completed.So users only need to start op-geth when using hildr.

@barnabasbusa
Copy link
Contributor Author

So hildr is incapable of block production without op-node?

@barnabasbusa
Copy link
Contributor Author

what does --enable-sequencer flag do then?

@thinkAfCod
Copy link

So hildr is incapable of block production without op-node?

yes, it is now.

@thinkAfCod
Copy link

what does --enable-sequencer flag do then?

This is predefined. Although it currently has no effect, it will be used to start the sequencer function once Hildr's sequencer feature is implemented.

@GrapeBaBa
Copy link

@barnabasbusa I am on vacation, @thinkAfCod would help to fix any blocking issue for this PR.

@barnabasbusa barnabasbusa marked this pull request as draft July 2, 2024 12:44
@GrapeBaBa
Copy link

@barnabasbusa please use latest version to check again.

@barnabasbusa
Copy link
Contributor Author

Looks a lot better, we seem to have hildr working with op-geth, op-reth, op-erigon

Screenshot 2024-07-15 at 14 51 41

@barnabasbusa barnabasbusa marked this pull request as ready for review July 15, 2024 12:52
@barnabasbusa barnabasbusa enabled auto-merge (squash) July 15, 2024 12:52
@barnabasbusa barnabasbusa requested a review from pk910 July 15, 2024 12:54
@barnabasbusa barnabasbusa merged commit e1ce08e into main Jul 15, 2024
5 checks passed
@barnabasbusa barnabasbusa deleted the bbusa/hildr branch July 15, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Hildr
4 participants