Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add do_xcom_push to BaseOperator config (default plugin) #120

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

peleyal
Copy link
Contributor

@peleyal peleyal commented Jun 7, 2021

do_xcom_push is the right way to use xcom in Airflow (xcom_push on k8s pod operator doesn't actually work on newer versions).

@peleyal peleyal marked this pull request as draft June 7, 2021 21:34
@peleyal peleyal closed this Jun 7, 2021
@peleyal peleyal reopened this Jun 7, 2021
@peleyal
Copy link
Contributor Author

peleyal commented Jun 7, 2021

@vchiapaikeo, I added this one in our plugin, but I think it can help other developers as well.

Thanks!

@peleyal peleyal marked this pull request as ready for review June 7, 2021 21:55
@vchiapaikeo
Copy link
Contributor

Hi @peleyal - we're going to start slowly working our way to Airflow 2.0 - hopefully that will happen by EOY. Until then though, I'd prefer not to merge this to master. We could consider merging this to a separate branch though.

@peleyal
Copy link
Contributor Author

peleyal commented Jun 8, 2021

Hi @peleyal - we're going to start slowly working our way to Airflow 2.0 - hopefully that will happen by EOY. Until then though, I'd prefer not to merge this to master. We could consider merging this to a separate branch though.

Thanks for the quick response.

I'm pretty sure it's not a feature of 2.0, as we are using Google Cloud Composer, and it runs with an older version Airflow.

Totally up to you, feel free to close this one.
I already merged it to our private plugin... I just wanted to avoid a case that other developers will be stuck on it (like I was).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants