fix: fix segmentation fault about bashreadline #288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two bugs that caused bpftime unable to run bashreadline (example/libbpf-tools/bashreadline)
--norc
. This is not fixed yet./bin/bash @ 0x123456
to/bin/ls
(a process that bash spawns). Under this way,resolve_function_addr_by_module_offset
is unable to resolve the real address that should be attached, it returns nullptr, so a segmentation fault will be raised if we invoke frida to add a invocation listener. This issue was solved by checking/proc/self/maps
and try to match each line for the desired module. If nothing was matched, we will reject this attachCloses #277