Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support separate find api access config #5

Merged
merged 2 commits into from
Aug 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions .github/workflows/helm-unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,11 @@ jobs:
contents: read
runs-on: ubuntu-latest
steps:
- name: Checkout repository
run: 'git clone -b "$BRANCH_OR_TAG_NAME" --depth 1 "$FULL_REPO_URL" app'
shell: bash
env:
FULL_REPO_URL: "https://github.com/${{ github.repository }}"
BRANCH_OR_TAG_NAME: ${{ github.ref_name }}
- name: Checkout
uses: actions/checkout@v4
with:
fetch-depth: 0
path: 'app'

- name: Run Helm Unit Tests
run: >
Expand Down
2 changes: 1 addition & 1 deletion charts/eurofurence-registration-system/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: eurofurence-registration-system
version: 0.0.26
version: 0.0.27
description: A helm chart that can deploy the Eurofurence Registration System.
type: application
home: https://github.com/eurofurence/reg-helm-chart
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ data:
allow_origin: '{{ . }}'
{{- end }}
require_login_for_reg: {{ .Values.system.components.attendee_service.require_login_for_reg }}
find_api_access: {{- .Values.choices.find_api_access | toYaml | nindent 8 }}
logging:
severity: {{ .Values.system.logging.severity }}
style: {{ .Values.system.logging.style }}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,10 @@ tests:
cors:
disable: false
require_login_for_reg: true
find_api_access:
permissions:
- regdesk
- sponsordesk
logging:
severity: INFO
style: ecs
Expand Down
15 changes: 15 additions & 0 deletions charts/eurofurence-registration-system/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -1239,6 +1239,21 @@
}
}
}
},
"find_api_access": {
"type": "object",
"description": "Configure permissions for the non-admin version of the find attendees API. Used by some on-site UIs and interfaces.",
"additionalProperties": false,
"properties": {
"permissions": {
"type": "array",
"description": "the list of permissions assigned to an attendee that will allow access to the find attendees api",
"items": {
"type": "string"
},
"default": ["regdesk","sponsordesk"]
}
}
}
}
},
Expand Down
6 changes: 5 additions & 1 deletion charts/eurofurence-registration-system/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,11 @@ choices:
sponsordesk:
permissions:
- sponsordesk

find_api_access:
permissions:
# minimum entries required for correct system operation
- regdesk
- sponsordesk
# development only - do NOT enable any of this for production, or you'll make the system insecure.
development:
cors:
Expand Down