Skip to content

Handle empty matches differently (and some optimizations) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Handle empty matches differently (and some optimizations) #2

wants to merge 4 commits into from

Conversation

aleclarson
Copy link

@aleclarson aleclarson commented Jul 17, 2018 •
edited
Loading

Changes I've made:

  • Handle empty matches differently
    • Exclude empty matches from the results
    • Increment the position instead of breaking out of the loop
       
  • Optimize non-global regexp
     
  • Optimize falsy string
     
  • Optimize first match
     

@aleclarson
handle empty matches differently
bbaf883 
1. Exclude empty matches from the results.
2. Increment the position instead of breaking out of the loop.
@aleclarson
optimize non-global regexp
2f91d74
@aleclarson
optimize falsy string
d33ac81
@aleclarson
optimize first match
84abd90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aleclarson