Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bmw hcaptcha link #17952

Merged
merged 6 commits into from
Jan 3, 2025
Merged

fix bmw hcaptcha link #17952

merged 6 commits into from
Jan 3, 2025

Conversation

fscherwi
Copy link
Contributor

@fscherwi fscherwi commented Dec 29, 2024 •
edited
Loading

Resolves the incorrect rendering of the underscores in the BMW hcaptcha link.

Before After

@andig andig requested a review from naltatis December 29, 2024 23:10
@andig andig added the ux User experience/ interface label Dec 29, 2024
@naltatis
Copy link
Member

@fscherwi magst du die Translations für die Config UI hier wieder rausnehmen. Das kollidiert sonst mit #12958 und hat ja erst einmal nichts mit dem BMW Link zu tun. Ein Thema pro PR ist immer ne gute Idee.

@fscherwi fscherwi changed the title fix bmw hcaptcha link and use translations for meter modal fix bmw hcaptcha link Dec 31, 2024
@fscherwi
Copy link
Contributor Author

@naltatis Erledigt

@naltatis naltatis merged commit 55cdccc into evcc-io:master Jan 3, 2025
6 checks passed
jonilala796 pushed a commit to jonilala796/evcc that referenced this pull request Jan 3, 2025
@fscherwi @jonilala796
docs: fix bmw hcaptcha link (evcc-io#17952)
6f47189
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andig andig andig left review comments

@naltatis naltatis naltatis left review comments

Assignees

@naltatis naltatis

Labels
ux User experience/ interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fscherwi @naltatis @andig