-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add wasm hooks #166
add wasm hooks #166
Conversation
Important Auto Review SkippedReview was skipped due to path filters Files ignored due to path filters (2)
WalkthroughThis update introduces the integration of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
3649299
to
9c240e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
go.mod
is excluded by:!**/*.mod
go.sum
is excluded by:!**/*.sum
Files selected for processing (1)
- app/app.go (8 hunks)
Additional comments: 8
app/app.go (8)
- 17-19: The imports for the
ibc-hooks
module have been correctly added, aligning with the PR's objective to integrate WASM hooks into the project.- 256-256: The declaration of
IBCHooksKeeper
is consistent with the PR's objective to integrate WASM hooks. It's important to ensure that the keeper is properly initialized and used throughout the application to leverage the hooks functionality effectively.- 331-331: The addition of
ibchookstypes.StoreKey
to the store keys is necessary for the integration of theibc-hooks
module. This change is consistent with the PR's objectives and ensures that the module's state can be stored and accessed correctly.- 678-680: The initialization of
IBCHooksKeeper
is correctly done here. However, it's crucial to ensure that this keeper is integrated into the application's logic where necessary, especially in relation to the IBC module and WASM contracts, to fully utilize the hooks functionality.- 682-684: The setup of WASM hooks using
ibchooks.NewWasmHooks
and the creation ofhooksICS4Wrapper
are key steps in integrating the WASM hooks functionality. It's important to verify that these hooks are correctly utilized in the IBC and WASM modules to intercept and handle the relevant IBC packets as intended.- 849-849: The inclusion of
ibchookstypes.ModuleName
in the order of BeginBlockers is crucial for ensuring that the WASM hooks are executed at the appropriate stage in the block lifecycle. This change aligns with the PR's objectives and is necessary for the correct operation of the hooks.- 869-869: Similarly, including
ibchookstypes.ModuleName
in the order of EndBlockers ensures that the WASM hooks are considered at the end of the block processing. This placement is important for the hooks' functionality and aligns with the integration goals.- 912-912: The addition of
ibchookstypes.ModuleName
in the order of InitGenesis is essential for initializing the WASM hooks module's state at the chain's start. This setup is consistent with the integration objectives and ensures that the hooks module is ready to operate from the genesis block.
Close issues
#128
Notes
This PR impl wasm hooks for eve
Summary by CodeRabbit