Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wasm hooks #166

Merged
merged 5 commits into from
Mar 14, 2024
Merged

add wasm hooks #166

merged 5 commits into from
Mar 14, 2024

Conversation

kienn6034
Copy link
Collaborator

@kienn6034 kienn6034 commented Mar 12, 2024

Close issues

#128

Notes

This PR impl wasm hooks for eve

  • bump wasm hooks to v8, and update tests
  • impl it into eve

Summary by CodeRabbit

  • New Features
    • Integrated IBC Hooks module to enhance inter-blockchain communication capabilities.

Copy link
Contributor

coderabbitai bot commented Mar 12, 2024

Important

Auto Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (2)
  • go.mod is excluded by: !**/*.mod
  • go.sum is excluded by: !**/*.sum

Walkthrough

This update introduces the integration of the ibc-hooks module into the application. It involves adding necessary imports, declaring and initializing the IBCHooksKeeper, and configuring related modules and middleware. Additionally, the module registration is updated to include ibchookstypes.ModuleName, enhancing the app's inter-blockchain communication capabilities.

Changes

File(s) Summary of Changes
app/app.go - Added ibc-hooks module imports
- Declared and initialized IBCHooksKeeper
- Updated module registration with ibchookstypes.ModuleName

🐇✨
To the code, we hop and leap,
With ibc-hooks, secrets we keep.
Across the chains, our messages fly,
Under the watch of the blockchain sky.
With every commit, a new dawn breaks,
For a world of connections, our code awakes.
🌟🚀

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@kienn6034 kienn6034 marked this pull request as draft March 12, 2024 10:25
@kienn6034 kienn6034 marked this pull request as ready for review March 14, 2024 11:37
@kienn6034 kienn6034 requested a review from hoank101 March 14, 2024 11:37
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 52433ed and 9c240e7.
Files ignored due to path filters (2)
  • go.mod is excluded by: !**/*.mod
  • go.sum is excluded by: !**/*.sum
Files selected for processing (1)
  • app/app.go (8 hunks)
Additional comments: 8
app/app.go (8)
  • 17-19: The imports for the ibc-hooks module have been correctly added, aligning with the PR's objective to integrate WASM hooks into the project.
  • 256-256: The declaration of IBCHooksKeeper is consistent with the PR's objective to integrate WASM hooks. It's important to ensure that the keeper is properly initialized and used throughout the application to leverage the hooks functionality effectively.
  • 331-331: The addition of ibchookstypes.StoreKey to the store keys is necessary for the integration of the ibc-hooks module. This change is consistent with the PR's objectives and ensures that the module's state can be stored and accessed correctly.
  • 678-680: The initialization of IBCHooksKeeper is correctly done here. However, it's crucial to ensure that this keeper is integrated into the application's logic where necessary, especially in relation to the IBC module and WASM contracts, to fully utilize the hooks functionality.
  • 682-684: The setup of WASM hooks using ibchooks.NewWasmHooks and the creation of hooksICS4Wrapper are key steps in integrating the WASM hooks functionality. It's important to verify that these hooks are correctly utilized in the IBC and WASM modules to intercept and handle the relevant IBC packets as intended.
  • 849-849: The inclusion of ibchookstypes.ModuleName in the order of BeginBlockers is crucial for ensuring that the WASM hooks are executed at the appropriate stage in the block lifecycle. This change aligns with the PR's objectives and is necessary for the correct operation of the hooks.
  • 869-869: Similarly, including ibchookstypes.ModuleName in the order of EndBlockers ensures that the WASM hooks are considered at the end of the block processing. This placement is important for the hooks' functionality and aligns with the integration goals.
  • 912-912: The addition of ibchookstypes.ModuleName in the order of InitGenesis is essential for initializing the WASM hooks module's state at the chain's start. This setup is consistent with the integration objectives and ensures that the hooks module is ready to operate from the genesis block.

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@kienn6034 kienn6034 requested a review from hoank101 March 14, 2024 14:47
@hoank101 hoank101 merged commit 2b42d37 into main Mar 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants