-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: integrate feeabs #175
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -5,6 +5,8 @@ import ( | |||||
|
||||||
ibcante "github.com/cosmos/ibc-go/v8/modules/core/ante" | ||||||
"github.com/cosmos/ibc-go/v8/modules/core/keeper" | ||||||
feeabsante "github.com/osmosis-labs/fee-abstraction/v8/x/feeabs/ante" | ||||||
feeabskeeper "github.com/osmosis-labs/fee-abstraction/v8/x/feeabs/keeper" | ||||||
|
||||||
corestoretypes "cosmossdk.io/core/store" | ||||||
circuitante "cosmossdk.io/x/circuit/ante" | ||||||
|
@@ -27,6 +29,7 @@ type HandlerOptions struct { | |||||
WasmKeeper *wasmkeeper.Keeper | ||||||
TXCounterStoreService corestoretypes.KVStoreService | ||||||
CircuitKeeper *circuitkeeper.Keeper | ||||||
FeeAbskeeper feeabskeeper.Keeper | ||||||
} | ||||||
|
||||||
// NewAnteHandler constructor | ||||||
|
@@ -57,11 +60,13 @@ func NewAnteHandler(options HandlerOptions) (sdk.AnteHandler, error) { | |||||
wasmkeeper.NewGasRegisterDecorator(options.WasmKeeper.GetGasRegister()), | ||||||
circuitante.NewCircuitBreakerDecorator(options.CircuitKeeper), | ||||||
ante.NewExtensionOptionsDecorator(options.ExtensionOptionChecker), | ||||||
feeabsante.NewFeeAbstrationMempoolFeeDecorator(options.FeeAbskeeper), | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There's a typographical error in the decorator function name - feeabsante.NewFeeAbstrationMempoolFeeDecorator(options.FeeAbskeeper),
+ feeabsante.NewFeeAbstractionMempoolFeeDecorator(options.FeeAbskeeper), Committable suggestion
Suggested change
|
||||||
|
||||||
ante.NewValidateBasicDecorator(), | ||||||
ante.NewTxTimeoutHeightDecorator(), | ||||||
ante.NewValidateMemoDecorator(options.AccountKeeper), | ||||||
ante.NewConsumeGasForTxSizeDecorator(options.AccountKeeper), | ||||||
feeabsante.NewFeeAbstractionDeductFeeDecorate(options.AccountKeeper, options.BankKeeper, options.FeeAbskeeper, options.FeegrantKeeper), | ||||||
ante.NewDeductFeeDecorator(options.AccountKeeper, options.BankKeeper, options.FeegrantKeeper, options.TxFeeChecker), | ||||||
ante.NewSetPubKeyDecorator(options.AccountKeeper), // SetPubKeyDecorator must be called before all signature verification decorators | ||||||
ante.NewValidateSigCountDecorator(options.AccountKeeper), | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tip
Codebase Verification
The verification process confirms that both
feeabsante
andfeeabskeeper
dependencies are missing from thego.sum
file. It's recommended to rungo mod tidy
to update thego.sum
file accordingly and avoid potential build failures.Analysis chain
The imports for
feeabsante
andfeeabskeeper
are correctly added to integrate fee abstraction functionalities. However, ensure that thego.sum
file is updated with these dependencies to avoid build failures. Runninggo mod tidy
should address this.Scripts Executed
The following scripts were executed for the analysis:
Script:
Length of output: 319
The import statements are not organized according to Go conventions, which recommend grouping and ordering imports for better readability. Consider using a tool like
gci
to automatically format the import statements.Committable suggestion