Allow MAX_SEQUENCES to be overriden on build #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful to not consume unnecessary SRAM when only requiring, e.g. a single sequence, giving the possibility of saving a fair amount of resources in such cases. In my testing, on Arduino UNO, setting EASYBUTTON_MAX_SEQUENCES to 1 saves 64 bytes.
|
Actually, this causes warnings about redefinition of the class (and doesn't work at all) when EASYBUTTON_MAX_SEQUENCES is anything other than 5, which is currently baffling me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Love the lib :)
This is useful to not consume unnecessary SRAM when only requiring, e.g. a single sequence, giving the possibility of saving a fair amount of resources in such cases.
In my testing, on Arduino UNO, setting EASYBUTTON_MAX_SEQUENCES to 1 saves 64 bytes.