-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate to sbt-ci-release #227
base: master
Are you sure you want to change the base?
migrate to sbt-ci-release #227
Conversation
I renamed packages to |
I think starting with 1.0.0 would only cause confusion as the change from On a side note: what is the motivation for such migration to Sonatype? Keeping our artifacts in external storage makes us depend on it, to which there can be several downsides:
|
I guess main motivation is to trully open source evolution libraries and publishing to maven through sonatype is well estabilished way in JVM ecosystem, tbh I don't know if you can do it in other way. All evo "open-source" libs are being built on developer machine and then published to evolution artifaactory. Personally, I'd never use such lib which isn't being built on github or at least it's not published to maven central because of security reasons. In evolution-gaming/scache#164 there was also a good reason about discoverability and how slightly harder is to use such lib. Regarding your concerns about long times and incovenience, I've never encountered such issues. I was both publishing and waiting to use newly published artifact, usually it was a matter of minutes rather than hours. Maybe sonatype<->maven improved over time and things are now better than it was few years ago?
I agree with you. I don't know how other people are doing it, but my workflow is following
To sum up, I couldn't care less about publishing to sonatype vs internal artifactory. . But if evolution has really good, battle-tested lib, which currently has no substitute in open soure, then why not to use that situation and gain some publicity among folks? :D cc: @t3hnar @Odomontois as you guys already did this for |
Is there anything preventing you from building any library locally and publishing to Sonatype manually provided you have the credentials (you're quite likely to have them if you've already set GH publishing up previously for the very same project)? Because of that, I don't think I understand why it addresses possible security issues.
I encountered those issues just recently, a few weeks back when I was publishing the aforementioned Overall, I don't have any objections to publishing to Sonatype (except for the minor commit history inconvenience I mentioned), just wanted to hear your thoughts on the motivation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! The only concern I have is changing the org name given this library is one of the foundational ones, and a lot of stuff is built on top of it, though I view it as a positive change overall. Let's wait for input from @t3hnar
- name: Publish artifacts | ||
env: | ||
SONATYPE_USERNAME: ${{ secrets.SONATYPE_USER }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need some special configuration for this repository? I don't know if it's necessary to add secrets to each repo manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have access to repo and organization secrets, but if it SONATYPE_USER
is an organization one, then adding it it's needed only once. Given fact that there are already 2 libraries which are using it, I assumed that this is already organization secret. Ca you check that? Also calling @t3hnar
When I think about it, this change shouldn't be disruptive and migration could be gradual. I mean for some time being, there will be
If I didn't forgot other cases, migration seems to be quite ok, as it's not breaking and must to do 🤔 |
We could also make a |
How are you going to notify users of old lib that there is a new one with different org name? |
How did you notify users when cats-helper disappeared from maven central and started to be published on evolution's artifactory? We can do the same method ;) I guess I'll write message on our company's slack ;) Cats-helper is not publicly available (in easy way) so I doubt that anyone outside evolution uses it. |
could you please explain this, because I'm not aware of publishing |
@t3hnar well I see that artifacts were published from 2019 to 2021, https://mvnrepository.com/artifact/com.evolutiongaming/cats-helper?repo=evolutiongaming. In the last published artifact, homepage is set to very this repo so I assume it is the same cats-helper about which we're talking right now ;) |
@kpodsiad if I click on any of the versions I can see the following at https://mvnrepository.com/repos/evolutiongaming:
bintray.com is not in the list of autoresolved repositories and is not accessed automatically… |
@t3hnar back in the days it was common to publish artifacts to bintray, wasn't it? Anyway, I just have assumed that something which is available on maven central, can be downloaded without any additional effort and this led to my half-serious comment ;) As I wrote, it is probably enough to announce this on evolution slack, as I doubt that people outside of evolution are using this library. My main motivation for this migration was evolution-gaming/scache#163, but if I can be honest, I don't think I have enough will to carry this task on as I don't need it personally. It seems just as a some work in order to achieve something that nobody really wanted explicitly :| |
I'd recommend to have one more last release with deprecation of major api calls and referencing to new artefact. It's pity that
I completely support you on this noble effort and I think this is a very useful work. My recent questions were rather caused by confusion after your statement, I seriously thought somebody deployed something manually to maven central… |
adapted from: evolution-gaming/scache#164
part of: evolution-gaming/scache#163
Steps which are needed to have easy to use scache on Scala 3:
TODO in this PR:
com.evolution
to be consistent with new organization name