Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve VQ measurment methodology #19

Merged
2 commits merged into from
Mar 21, 2024
Merged

Improve VQ measurment methodology #19

2 commits merged into from
Mar 21, 2024

Conversation

jurisevo
Copy link
Collaborator

@jurisevo jurisevo commented Mar 11, 2024 •
edited
Loading

With this change-set a few potential problems are being addressed:

  1. Explicit check for matching number of frames in source and compressed video. This will emphasize issues where a frame misalignment (due to skipped/dropped frames) may skew VQ metrics.
  2. Extend collected metrics with aggregate values which should improve detection of low quality sections in encoded video.

@jurisevo
Detect cases with potential misaligned frames
58ef5f8 
Source and compressed videos should have equal number of frames, otherwise
there is a potential for frame misalignment which will degrade VQ
metrics.
@jurisevo jurisevo force-pushed the VQ-measurement-improvements branch from 263563c to aac82a6 Compare March 20, 2024 08:29
@jurisevo jurisevo changed the title Detect cases with potential misaligned frames Improve VQ measurment methodology Mar 20, 2024
@jurisevo
Add central store for metrics
fa551d0 
This change-set was a bit more involved and required refactoring and
removing of some old concepts.

Changes:

- Add metric package with metric Store and Record implementation
- Only write CSV report file, no longer write JSON report which was the
  artefact of time when ease was 2 separate applications.
- Improve test coverage for new-plan subcommand.
- Bump go version in go.mod file to 1.20, since we are using
  atomic.Int64 which is not supported by go 1.18.
@jurisevo jurisevo force-pushed the VQ-measurement-improvements branch from aac82a6 to fa551d0 Compare March 20, 2024 11:45
@jurisevo jurisevo closed this pull request by merging all changes into main in fa551d0 Mar 21, 2024
@jurisevo jurisevo deleted the VQ-measurement-improvements branch March 21, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jurisevo