Bump play-json-jsoniter to 1.1.1 #639
Conversation
Pull Request Test Coverage Report for Build 9873751455Details
💛 - Coveralls |
| @@ -1 +1 @@ | |||
| ThisBuild / version := "3.4.1-SNAPSHOT" | |||
| ThisBuild / version := "4.0.0" | |||
There was a problem hiding this comment.
@dfakhritdinov, I suppose we are not ready for this, yet :)
@odbc, we have a lot more of cleanup and changes planned for 4.0.0 and we'd like to postpone release of 4.0.0 for a while.
How play-json-jsoniter 1.1.1 differs from 0.10.2 besides package and version? is it otherwise binary compatible?
There was a problem hiding this comment.
@odbc @mr-git @dfakhritdinov What do you think about contribution of play-json-jsoniter to jsoniter-scala repo?
It can fix publishing to the Maven Central and missing artifacts for Scala 3 and Scala Native.
Also, per commit MiMa checks will guarantee backward binary compatibility for minor versions and both directions (backward and forward binary compatibility) for patch versions.
/cc @t3hnar
There was a problem hiding this comment.
How play-json-jsoniter 1.1.1 differs from 0.10.2 besides package and version? is it otherwise binary compatible?
Yes, it should be actually compatible. Looking at diff I noticed only some changes in signatures of internal API (JsonValueCodecJsValue.apply)
But the versions compatibility checker considers play-json-jsoniter versions binary incompatible and makes the PR red
There was a problem hiding this comment.
Its not only about making the PR green 😞
Almost all Evolution libs/apps are using semver thus the bump of play-json-jsoniter version will end-up with bumping it everywhere where its present (transitively). I agree with @mr-git and prefer to combine major version bump with some other planned maintenance.
@odbc, how urgent is the PR?
There was a problem hiding this comment.
@odbc, how urgent is the PR?
It can wait until your major update
There was a problem hiding this comment.
Hi there!
@plokhotnyuk
I can try to help with play-json-jsoniter -> jsoniter-scala contribution if nobody minds
cc: @dfakhritdinov
|
closed in favor of #664 |
Play-json-jsoniter diff