Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 2.12 support, prepare for 1.1.0 changes #5

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

migesok
Copy link
Contributor

@migesok migesok commented Aug 30, 2024

also

  • added MiMa bincompat checks
  • updated scalafmt

also
- added MiMa bincompat checks
- updated scalafmt
@migesok migesok requested a review from mr-git August 30, 2024 11:18
@coveralls
Copy link

coveralls commented Aug 30, 2024

Pull Request Test Coverage Report for Build 10631760794

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.571%

Totals Coverage Status
Change from base Build 9445367412: 0.0%
Covered Lines: 10
Relevant Lines: 35

💛 - Coveralls

Comment on lines +19 to +23
if (scalaBinaryVersion.value == "2.13") {
Seq(
"-Xsource:3"
)
} else Seq.empty
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe?

Suggested change
if (scalaBinaryVersion.value == "2.13") {
Seq(
"-Xsource:3"
)
} else Seq.empty
if (scalaBinaryVersion.value == "2.13") Seq("-Xsource:3")
else Seq.empty

Comment on lines +54 to 56
override def timeTillNowNanos[T](start: T)(implicit
numeric: Numeric[T]
): Unit = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we?:

Suggested change
override def timeTillNowNanos[T](start: T)(implicit
numeric: Numeric[T]
): Unit = {
override def timeTillNowNanos[T](start: T)(implicit numeric: Numeric[T]): Unit = {

Copy link
Contributor

@mr-git mr-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@migesok migesok merged commit b86b650 into master Aug 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants