-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop 2.12 support, prepare for 1.1.0 changes #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also - added MiMa bincompat checks - updated scalafmt
Pull Request Test Coverage Report for Build 10631760794Details
💛 - Coveralls |
mr-git
reviewed
Aug 30, 2024
Comment on lines
+19
to
+23
if (scalaBinaryVersion.value == "2.13") { | ||
Seq( | ||
"-Xsource:3" | ||
) | ||
} else Seq.empty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe?
Suggested change
if (scalaBinaryVersion.value == "2.13") { | |
Seq( | |
"-Xsource:3" | |
) | |
} else Seq.empty | |
if (scalaBinaryVersion.value == "2.13") Seq("-Xsource:3") | |
else Seq.empty |
Comment on lines
+54
to
56
override def timeTillNowNanos[T](start: T)(implicit | ||
numeric: Numeric[T] | ||
): Unit = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we?:
Suggested change
override def timeTillNowNanos[T](start: T)(implicit | |
numeric: Numeric[T] | |
): Unit = { | |
override def timeTillNowNanos[T](start: T)(implicit numeric: Numeric[T]): Unit = { |
mr-git
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also